How to make a new call with Retrofit2?
I am currently working with Retrofit2 and I was wondering the best way to make a new call.
In my current app, I have a Service that implements the singleton pattern :
public final class Services
{
private static volatile Services instance;
public static Services getInstance()
{
if (instance == null)
{
synchronized (Services.class)
{
if (instance == null)
{
instance = new Services();
}
}
}
return instance;
}
private final IServices myServices;
public Services()
{
final Retrofit.Builder retrofitBuilder = new Retrofit.Builder();
retrofitBuilder.client(new OkHttpClient.Builder().build());
myServices = retrofitBuilder.build().create(IServices.class);
}
public void myCall(@NonNull String param)
{
//...
}
}
Into the myCall method, I do the call, for example : myServices.aGetRequest(param).execute();
Now, I would like, for example, to modify the request (add some headers for example) but with no interceptor and make the call. What is the best way ?
From the IServices interface, I do not have access to the okhttp3.Call.Factory in order to call the newCall. But I have this access from the Retrofit class with the callFactory method.
Is it a good pattern to keep a reference to the IServices and to the Retrofit classes into the Services class in order to do something like that into the myCall method ?
public void myCall(@NonNull String param)
{
retrofit.callFactory().newCall(myServices.aGetRequest(param).request().newBuilder().addHeader("MY_HEADER_KEY", "MY_HEADER_VALUE").build()).execute();
}
android retrofit2 asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
add a comment |
I am currently working with Retrofit2 and I was wondering the best way to make a new call.
In my current app, I have a Service that implements the singleton pattern :
public final class Services
{
private static volatile Services instance;
public static Services getInstance()
{
if (instance == null)
{
synchronized (Services.class)
{
if (instance == null)
{
instance = new Services();
}
}
}
return instance;
}
private final IServices myServices;
public Services()
{
final Retrofit.Builder retrofitBuilder = new Retrofit.Builder();
retrofitBuilder.client(new OkHttpClient.Builder().build());
myServices = retrofitBuilder.build().create(IServices.class);
}
public void myCall(@NonNull String param)
{
//...
}
}
Into the myCall method, I do the call, for example : myServices.aGetRequest(param).execute();
Now, I would like, for example, to modify the request (add some headers for example) but with no interceptor and make the call. What is the best way ?
From the IServices interface, I do not have access to the okhttp3.Call.Factory in order to call the newCall. But I have this access from the Retrofit class with the callFactory method.
Is it a good pattern to keep a reference to the IServices and to the Retrofit classes into the Services class in order to do something like that into the myCall method ?
public void myCall(@NonNull String param)
{
retrofit.callFactory().newCall(myServices.aGetRequest(param).request().newBuilder().addHeader("MY_HEADER_KEY", "MY_HEADER_VALUE").build()).execute();
}
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
Use an interceptor for adding the headers. It's the way to go!
– finki
Nov 13 '18 at 9:43
add a comment |
I am currently working with Retrofit2 and I was wondering the best way to make a new call.
In my current app, I have a Service that implements the singleton pattern :
public final class Services
{
private static volatile Services instance;
public static Services getInstance()
{
if (instance == null)
{
synchronized (Services.class)
{
if (instance == null)
{
instance = new Services();
}
}
}
return instance;
}
private final IServices myServices;
public Services()
{
final Retrofit.Builder retrofitBuilder = new Retrofit.Builder();
retrofitBuilder.client(new OkHttpClient.Builder().build());
myServices = retrofitBuilder.build().create(IServices.class);
}
public void myCall(@NonNull String param)
{
//...
}
}
Into the myCall method, I do the call, for example : myServices.aGetRequest(param).execute();
Now, I would like, for example, to modify the request (add some headers for example) but with no interceptor and make the call. What is the best way ?
From the IServices interface, I do not have access to the okhttp3.Call.Factory in order to call the newCall. But I have this access from the Retrofit class with the callFactory method.
Is it a good pattern to keep a reference to the IServices and to the Retrofit classes into the Services class in order to do something like that into the myCall method ?
public void myCall(@NonNull String param)
{
retrofit.callFactory().newCall(myServices.aGetRequest(param).request().newBuilder().addHeader("MY_HEADER_KEY", "MY_HEADER_VALUE").build()).execute();
}
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
I am currently working with Retrofit2 and I was wondering the best way to make a new call.
In my current app, I have a Service that implements the singleton pattern :
public final class Services
{
private static volatile Services instance;
public static Services getInstance()
{
if (instance == null)
{
synchronized (Services.class)
{
if (instance == null)
{
instance = new Services();
}
}
}
return instance;
}
private final IServices myServices;
public Services()
{
final Retrofit.Builder retrofitBuilder = new Retrofit.Builder();
retrofitBuilder.client(new OkHttpClient.Builder().build());
myServices = retrofitBuilder.build().create(IServices.class);
}
public void myCall(@NonNull String param)
{
//...
}
}
Into the myCall method, I do the call, for example : myServices.aGetRequest(param).execute();
Now, I would like, for example, to modify the request (add some headers for example) but with no interceptor and make the call. What is the best way ?
From the IServices interface, I do not have access to the okhttp3.Call.Factory in order to call the newCall. But I have this access from the Retrofit class with the callFactory method.
Is it a good pattern to keep a reference to the IServices and to the Retrofit classes into the Services class in order to do something like that into the myCall method ?
public void myCall(@NonNull String param)
{
retrofit.callFactory().newCall(myServices.aGetRequest(param).request().newBuilder().addHeader("MY_HEADER_KEY", "MY_HEADER_VALUE").build()).execute();
}
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
asked Nov 13 '18 at 9:17
rolandlrolandl
6261231
6261231
Use an interceptor for adding the headers. It's the way to go!
– finki
Nov 13 '18 at 9:43
add a comment |
Use an interceptor for adding the headers. It's the way to go!
– finki
Nov 13 '18 at 9:43
Use an interceptor for adding the headers. It's the way to go!
– finki
Nov 13 '18 at 9:43
Use an interceptor for adding the headers. It's the way to go!
– finki
Nov 13 '18 at 9:43
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53277564%2fhow-to-make-a-new-call-with-retrofit2%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53277564%2fhow-to-make-a-new-call-with-retrofit2%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Use an interceptor for adding the headers. It's the way to go!
– finki
Nov 13 '18 at 9:43