Why findOneAndUpdate runs .then even if returned object was null? Mongoose
This is my code:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user.toAuthJSON() }) )
.catch(err => res.json({ err }));
)
When there isn't any user with such confirmationToken, findOneAndUpdate returns null but why it runs .then instead of .catch? Shloudn't it run .then when user is returned and run .catch when returned is NULL instead of user object?
reactjs mongodb mongoose
asked Nov 14 '18 at 19:01
MimoidMimoid
198
add a comment |
This is my code:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user.toAuthJSON() }) )
.catch(err => res.json({ err }));
)
When there isn't any user with such confirmationToken, findOneAndUpdate returns null but why it runs .then instead of .catch? Shloudn't it run .then when user is returned and run .catch when returned is NULL instead of user object?
reactjs mongodb mongoose
asked Nov 14 '18 at 19:01
MimoidMimoid
198
add a comment |
This is my code:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user.toAuthJSON() }) )
.catch(err => res.json({ err }));
)
When there isn't any user with such confirmationToken, findOneAndUpdate returns null but why it runs .then instead of .catch? Shloudn't it run .then when user is returned and run .catch when returned is NULL instead of user object?
reactjs mongodb mongoose
asked Nov 14 '18 at 19:01
MimoidMimoid
198
This is my code:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user.toAuthJSON() }) )
.catch(err => res.json({ err }));
)
When there isn't any user with such confirmationToken, findOneAndUpdate returns null but why it runs .then instead of .catch? Shloudn't it run .then when user is returned and run .catch when returned is NULL instead of user object?
reactjs mongodb mongoose
reactjs mongodb mongoose
asked Nov 14 '18 at 19:01
MimoidMimoid
198
asked Nov 14 '18 at 19:01
MimoidMimoid
198
asked Nov 14 '18 at 19:01
MimoidMimoid
198
asked Nov 14 '18 at 19:01
MimoidMimoid
198
asked Nov 14 '18 at 19:01
MimoidMimoid
198
198
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
Returning null is valid response. To protect your code from that you could:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user ? user.toAuthJSON() : user }) )
.catch(err => res.json({ err }));
)
Or you could throw inside your .then if hitting the catch is what you really want.
As per mongoose docs on Model.findOneAndUpdate:
Finds a matching document, updates it according to the update arg,
passing any options, and returns the found document (if any) to the
callback.
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
add a comment |
catch runs when an error occurred, for example:
Error in mongoose validation or when you want update a document in collection and some errors occurred.
answered Nov 14 '18 at 19:28
afshinafshin
11
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53307081%2fwhy-findoneandupdate-runs-then-even-if-returned-object-was-null-mongoose%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
Returning null is valid response. To protect your code from that you could:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user ? user.toAuthJSON() : user }) )
.catch(err => res.json({ err }));
)
Or you could throw inside your .then if hitting the catch is what you really want.
As per mongoose docs on Model.findOneAndUpdate:
Finds a matching document, updates it according to the update arg,
passing any options, and returns the found document (if any) to the
callback.
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
add a comment |
Returning null is valid response. To protect your code from that you could:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user ? user.toAuthJSON() : user }) )
.catch(err => res.json({ err }));
)
Or you could throw inside your .then if hitting the catch is what you really want.
As per mongoose docs on Model.findOneAndUpdate:
Finds a matching document, updates it according to the update arg,
passing any options, and returns the found document (if any) to the
callback.
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
add a comment |
Returning null is valid response. To protect your code from that you could:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user ? user.toAuthJSON() : user }) )
.catch(err => res.json({ err }));
)
Or you could throw inside your .then if hitting the catch is what you really want.
As per mongoose docs on Model.findOneAndUpdate:
Finds a matching document, updates it according to the update arg,
passing any options, and returns the found document (if any) to the
callback.
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
Returning null is valid response. To protect your code from that you could:
User.findOneAndUpdate(
{ confirmationToken: "blablabla" },
{ confirmationToken: "", confirmed: true },
{ new: true }
)
.then(user => res.json({ user: user ? user.toAuthJSON() : user }) )
.catch(err => res.json({ err }));
)
Or you could throw inside your .then if hitting the catch is what you really want.
As per mongoose docs on Model.findOneAndUpdate:
Finds a matching document, updates it according to the update arg,
passing any options, and returns the found document (if any) to the
callback.
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
answered Nov 14 '18 at 19:08
AkrionAkrion
9,48511224
9,48511224
add a comment |
add a comment |
catch runs when an error occurred, for example:
Error in mongoose validation or when you want update a document in collection and some errors occurred.
answered Nov 14 '18 at 19:28
afshinafshin
11
add a comment |
catch runs when an error occurred, for example:
Error in mongoose validation or when you want update a document in collection and some errors occurred.
answered Nov 14 '18 at 19:28
afshinafshin
11
add a comment |
catch runs when an error occurred, for example:
Error in mongoose validation or when you want update a document in collection and some errors occurred.
answered Nov 14 '18 at 19:28
afshinafshin
11
catch runs when an error occurred, for example:
Error in mongoose validation or when you want update a document in collection and some errors occurred.
answered Nov 14 '18 at 19:28
afshinafshin
11
answered Nov 14 '18 at 19:28
afshinafshin
11
answered Nov 14 '18 at 19:28
afshinafshin
11
answered Nov 14 '18 at 19:28
afshinafshin
11
11
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53307081%2fwhy-findoneandupdate-runs-then-even-if-returned-object-was-null-mongoose%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
