C allocating char array causing bad access runtime exception
0
I seem to be having trouble correctly allocating memory for my array. The method is returning as expected, but a runtime exception is killing the program.
I got this exception while using my debugger.
EXC_BAD_ACCESS (code=1, address=0x0)
This is the method causing the issue:
char *progScanner(char *line){
char originalLine[100];
strcpy(originalLine, line);
char *correctLine[100];
char *segment;
int i = 0;
segment = strtok(originalLine," ,()");
while (segment != NULL){
printf (" %s",segment);
correctLine[i++] = segment;
segment = strtok (NULL, " ,()");
}
char *newLine;
newLine = malloc(100 * sizeof(char));
int j = 1;
strcpy (newLine, correctLine[0]);
while(j<=i){
strcat(newLine, correctLine[j]);
j++;
}
return newLine;
}
c memory-management runtime
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
|
show 2 more comments
0
I seem to be having trouble correctly allocating memory for my array. The method is returning as expected, but a runtime exception is killing the program.
I got this exception while using my debugger.
EXC_BAD_ACCESS (code=1, address=0x0)
This is the method causing the issue:
char *progScanner(char *line){
char originalLine[100];
strcpy(originalLine, line);
char *correctLine[100];
char *segment;
int i = 0;
segment = strtok(originalLine," ,()");
while (segment != NULL){
printf (" %s",segment);
correctLine[i++] = segment;
segment = strtok (NULL, " ,()");
}
char *newLine;
newLine = malloc(100 * sizeof(char));
int j = 1;
strcpy (newLine, correctLine[0]);
while(j<=i){
strcat(newLine, correctLine[j]);
j++;
}
return newLine;
}
c memory-management runtime
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
Are you sure the original line is less than 100 characters long? If it's longer, you'll cause undefined behavior.
– Barmar
Nov 13 '18 at 22:14
The error indicates that you're trying to dereference a null pointer. Step through the code with a debugger to see where this is happening.
– Barmar
Nov 13 '18 at 22:15
2
while(j<=i)should bewhile(j<i).
– Barmar
Nov 13 '18 at 22:17
1
Unrelated, but the use ofstrcatin a loop like this is a textbook case of Schlemiel The Painter. joelonsoftware.com/2001/12/11/back-to-basics
– Christian Gibbons
Nov 13 '18 at 22:36
@Barmar you're right, please leave an answer. Can't believe I missed that for so long.
– Voxorin
Nov 13 '18 at 23:38
|
show 2 more comments
0
0
0
I seem to be having trouble correctly allocating memory for my array. The method is returning as expected, but a runtime exception is killing the program.
I got this exception while using my debugger.
EXC_BAD_ACCESS (code=1, address=0x0)
This is the method causing the issue:
char *progScanner(char *line){
char originalLine[100];
strcpy(originalLine, line);
char *correctLine[100];
char *segment;
int i = 0;
segment = strtok(originalLine," ,()");
while (segment != NULL){
printf (" %s",segment);
correctLine[i++] = segment;
segment = strtok (NULL, " ,()");
}
char *newLine;
newLine = malloc(100 * sizeof(char));
int j = 1;
strcpy (newLine, correctLine[0]);
while(j<=i){
strcat(newLine, correctLine[j]);
j++;
}
return newLine;
}
c memory-management runtime
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
I seem to be having trouble correctly allocating memory for my array. The method is returning as expected, but a runtime exception is killing the program.
I got this exception while using my debugger.
EXC_BAD_ACCESS (code=1, address=0x0)
This is the method causing the issue:
char *progScanner(char *line){
char originalLine[100];
strcpy(originalLine, line);
char *correctLine[100];
char *segment;
int i = 0;
segment = strtok(originalLine," ,()");
while (segment != NULL){
printf (" %s",segment);
correctLine[i++] = segment;
segment = strtok (NULL, " ,()");
}
char *newLine;
newLine = malloc(100 * sizeof(char));
int j = 1;
strcpy (newLine, correctLine[0]);
while(j<=i){
strcat(newLine, correctLine[j]);
j++;
}
return newLine;
}
c memory-management runtime
c memory-management runtime
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
asked Nov 13 '18 at 22:08
VoxorinVoxorin
177
177
Are you sure the original line is less than 100 characters long? If it's longer, you'll cause undefined behavior.
– Barmar
Nov 13 '18 at 22:14
The error indicates that you're trying to dereference a null pointer. Step through the code with a debugger to see where this is happening.
– Barmar
Nov 13 '18 at 22:15
2
while(j<=i)should bewhile(j<i).
– Barmar
Nov 13 '18 at 22:17
1
Unrelated, but the use ofstrcatin a loop like this is a textbook case of Schlemiel The Painter. joelonsoftware.com/2001/12/11/back-to-basics
– Christian Gibbons
Nov 13 '18 at 22:36
@Barmar you're right, please leave an answer. Can't believe I missed that for so long.
– Voxorin
Nov 13 '18 at 23:38
|
show 2 more comments
Are you sure the original line is less than 100 characters long? If it's longer, you'll cause undefined behavior.
– Barmar
Nov 13 '18 at 22:14
The error indicates that you're trying to dereference a null pointer. Step through the code with a debugger to see where this is happening.
– Barmar
Nov 13 '18 at 22:15
2
while(j<=i)should bewhile(j<i).
– Barmar
Nov 13 '18 at 22:17
1
Unrelated, but the use ofstrcatin a loop like this is a textbook case of Schlemiel The Painter. joelonsoftware.com/2001/12/11/back-to-basics
– Christian Gibbons
Nov 13 '18 at 22:36
@Barmar you're right, please leave an answer. Can't believe I missed that for so long.
– Voxorin
Nov 13 '18 at 23:38
Are you sure the original line is less than 100 characters long? If it's longer, you'll cause undefined behavior.
– Barmar
Nov 13 '18 at 22:14
Are you sure the original line is less than 100 characters long? If it's longer, you'll cause undefined behavior.
– Barmar
Nov 13 '18 at 22:14
The error indicates that you're trying to dereference a null pointer. Step through the code with a debugger to see where this is happening.
– Barmar
Nov 13 '18 at 22:15
The error indicates that you're trying to dereference a null pointer. Step through the code with a debugger to see where this is happening.
– Barmar
Nov 13 '18 at 22:15
2
2
while(j<=i) should be while(j<i).– Barmar
Nov 13 '18 at 22:17
while(j<=i) should be while(j<i).– Barmar
Nov 13 '18 at 22:17
1
1
Unrelated, but the use of
strcat in a loop like this is a textbook case of Schlemiel The Painter. joelonsoftware.com/2001/12/11/back-to-basics– Christian Gibbons
Nov 13 '18 at 22:36
Unrelated, but the use of
strcat in a loop like this is a textbook case of Schlemiel The Painter. joelonsoftware.com/2001/12/11/back-to-basics– Christian Gibbons
Nov 13 '18 at 22:36
@Barmar you're right, please leave an answer. Can't believe I missed that for so long.
– Voxorin
Nov 13 '18 at 23:38
@Barmar you're right, please leave an answer. Can't believe I missed that for so long.
– Voxorin
Nov 13 '18 at 23:38
|
show 2 more comments
1 Answer
1
active
oldest
votes
0
You're accessing outside the correctLine array when you get to j == i, because the last valid index in correctLine is j-1. Change
while(j<=i){
to
while(j<i){
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53290243%2fc-allocating-char-array-causing-bad-access-runtime-exception%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
0
You're accessing outside the correctLine array when you get to j == i, because the last valid index in correctLine is j-1. Change
while(j<=i){
to
while(j<i){
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
add a comment |
0
You're accessing outside the correctLine array when you get to j == i, because the last valid index in correctLine is j-1. Change
while(j<=i){
to
while(j<i){
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
add a comment |
0
0
0
You're accessing outside the correctLine array when you get to j == i, because the last valid index in correctLine is j-1. Change
while(j<=i){
to
while(j<i){
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
You're accessing outside the correctLine array when you get to j == i, because the last valid index in correctLine is j-1. Change
while(j<=i){
to
while(j<i){
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
answered Nov 14 '18 at 6:10
BarmarBarmar
425k36248349
425k36248349
add a comment |
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53290243%2fc-allocating-char-array-causing-bad-access-runtime-exception%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Are you sure the original line is less than 100 characters long? If it's longer, you'll cause undefined behavior.
– Barmar
Nov 13 '18 at 22:14
The error indicates that you're trying to dereference a null pointer. Step through the code with a debugger to see where this is happening.
– Barmar
Nov 13 '18 at 22:15
2
while(j<=i)should bewhile(j<i).– Barmar
Nov 13 '18 at 22:17
1
Unrelated, but the use of
strcatin a loop like this is a textbook case of Schlemiel The Painter. joelonsoftware.com/2001/12/11/back-to-basics– Christian Gibbons
Nov 13 '18 at 22:36
@Barmar you're right, please leave an answer. Can't believe I missed that for so long.
– Voxorin
Nov 13 '18 at 23:38