Injecting a service in spring boot filter












0














Have a filter where a service is autowired.
I am injecting the service as constructor argument - from the config where filter is registered.



MyFilter implements filter {
private final ServiceToBeInjected serviceToBeInjected;

public MyFilter(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}
}

public class ConfigClass {
private final ServiceToBeInjected serviceToBeInjected;

@Autowired
public ConfigClass(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}

@Bean
public FilterRegistrationBean<MyFilter> filterRegistrationBean() {
final FilterRegistrationBean<MyFilter> filterRegBean = new FilterRegistrationBean<>();
filterRegBean.setFilter(new MyFilter(serviceToBeInjected));
filterRegBean.addUrlPatterns(");
return filterRegBean;
}
}


I kind of felt autowiring from config might not be good.
Is there any other better way ?










share|improve this question
























  • Please learn correct indentation. It was unreadable. Fixed it for you this time.
    – Michael
    Nov 12 at 8:51










  • filter is a class? see stackoverflow.com/questions/32494398/…
    – user7294900
    Nov 12 at 8:53


















0














Have a filter where a service is autowired.
I am injecting the service as constructor argument - from the config where filter is registered.



MyFilter implements filter {
private final ServiceToBeInjected serviceToBeInjected;

public MyFilter(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}
}

public class ConfigClass {
private final ServiceToBeInjected serviceToBeInjected;

@Autowired
public ConfigClass(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}

@Bean
public FilterRegistrationBean<MyFilter> filterRegistrationBean() {
final FilterRegistrationBean<MyFilter> filterRegBean = new FilterRegistrationBean<>();
filterRegBean.setFilter(new MyFilter(serviceToBeInjected));
filterRegBean.addUrlPatterns(");
return filterRegBean;
}
}


I kind of felt autowiring from config might not be good.
Is there any other better way ?










share|improve this question
























  • Please learn correct indentation. It was unreadable. Fixed it for you this time.
    – Michael
    Nov 12 at 8:51










  • filter is a class? see stackoverflow.com/questions/32494398/…
    – user7294900
    Nov 12 at 8:53
















0












0








0







Have a filter where a service is autowired.
I am injecting the service as constructor argument - from the config where filter is registered.



MyFilter implements filter {
private final ServiceToBeInjected serviceToBeInjected;

public MyFilter(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}
}

public class ConfigClass {
private final ServiceToBeInjected serviceToBeInjected;

@Autowired
public ConfigClass(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}

@Bean
public FilterRegistrationBean<MyFilter> filterRegistrationBean() {
final FilterRegistrationBean<MyFilter> filterRegBean = new FilterRegistrationBean<>();
filterRegBean.setFilter(new MyFilter(serviceToBeInjected));
filterRegBean.addUrlPatterns(");
return filterRegBean;
}
}


I kind of felt autowiring from config might not be good.
Is there any other better way ?










share|improve this question















Have a filter where a service is autowired.
I am injecting the service as constructor argument - from the config where filter is registered.



MyFilter implements filter {
private final ServiceToBeInjected serviceToBeInjected;

public MyFilter(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}
}

public class ConfigClass {
private final ServiceToBeInjected serviceToBeInjected;

@Autowired
public ConfigClass(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}

@Bean
public FilterRegistrationBean<MyFilter> filterRegistrationBean() {
final FilterRegistrationBean<MyFilter> filterRegBean = new FilterRegistrationBean<>();
filterRegBean.setFilter(new MyFilter(serviceToBeInjected));
filterRegBean.addUrlPatterns(");
return filterRegBean;
}
}


I kind of felt autowiring from config might not be good.
Is there any other better way ?







java spring-boot dependency-injection autowired






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 12 at 11:31

























asked Nov 12 at 8:43









Parameswar

41261131




41261131












  • Please learn correct indentation. It was unreadable. Fixed it for you this time.
    – Michael
    Nov 12 at 8:51










  • filter is a class? see stackoverflow.com/questions/32494398/…
    – user7294900
    Nov 12 at 8:53




















  • Please learn correct indentation. It was unreadable. Fixed it for you this time.
    – Michael
    Nov 12 at 8:51










  • filter is a class? see stackoverflow.com/questions/32494398/…
    – user7294900
    Nov 12 at 8:53


















Please learn correct indentation. It was unreadable. Fixed it for you this time.
– Michael
Nov 12 at 8:51




Please learn correct indentation. It was unreadable. Fixed it for you this time.
– Michael
Nov 12 at 8:51












filter is a class? see stackoverflow.com/questions/32494398/…
– user7294900
Nov 12 at 8:53






filter is a class? see stackoverflow.com/questions/32494398/…
– user7294900
Nov 12 at 8:53














1 Answer
1






active

oldest

votes


















0














If MyFilter is only constructed once then it can be a component, which means it will be autowired implicitly.



@Component
MyFilter implements Filter {
private final ServiceToBeInjected;

// Autowired implicitly
public MyFilter(ServiceToBeInjected serviceToBeInjected) {
this.serviceToBeInjected = serviceToBeInjected;
}
}


Your bean can then take the filter as a method parameter



public class ConfigClass {
@Bean
public FilterRegistrationBean<MyFilter> foo(final MyFilter filter) {
final FilterRegistrationBean<MyFilter> bean = new FilterRegistrationBean<>();
bean.setFilter(filter);
bean.addUrlPatterns(");
return bean;
}
}


If MyFilter needs to be constructed more than once then what you've done is fine.






share|improve this answer























    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53258493%2finjecting-a-service-in-spring-boot-filter%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    0














    If MyFilter is only constructed once then it can be a component, which means it will be autowired implicitly.



    @Component
    MyFilter implements Filter {
    private final ServiceToBeInjected;

    // Autowired implicitly
    public MyFilter(ServiceToBeInjected serviceToBeInjected) {
    this.serviceToBeInjected = serviceToBeInjected;
    }
    }


    Your bean can then take the filter as a method parameter



    public class ConfigClass {
    @Bean
    public FilterRegistrationBean<MyFilter> foo(final MyFilter filter) {
    final FilterRegistrationBean<MyFilter> bean = new FilterRegistrationBean<>();
    bean.setFilter(filter);
    bean.addUrlPatterns(");
    return bean;
    }
    }


    If MyFilter needs to be constructed more than once then what you've done is fine.






    share|improve this answer




























      0














      If MyFilter is only constructed once then it can be a component, which means it will be autowired implicitly.



      @Component
      MyFilter implements Filter {
      private final ServiceToBeInjected;

      // Autowired implicitly
      public MyFilter(ServiceToBeInjected serviceToBeInjected) {
      this.serviceToBeInjected = serviceToBeInjected;
      }
      }


      Your bean can then take the filter as a method parameter



      public class ConfigClass {
      @Bean
      public FilterRegistrationBean<MyFilter> foo(final MyFilter filter) {
      final FilterRegistrationBean<MyFilter> bean = new FilterRegistrationBean<>();
      bean.setFilter(filter);
      bean.addUrlPatterns(");
      return bean;
      }
      }


      If MyFilter needs to be constructed more than once then what you've done is fine.






      share|improve this answer


























        0












        0








        0






        If MyFilter is only constructed once then it can be a component, which means it will be autowired implicitly.



        @Component
        MyFilter implements Filter {
        private final ServiceToBeInjected;

        // Autowired implicitly
        public MyFilter(ServiceToBeInjected serviceToBeInjected) {
        this.serviceToBeInjected = serviceToBeInjected;
        }
        }


        Your bean can then take the filter as a method parameter



        public class ConfigClass {
        @Bean
        public FilterRegistrationBean<MyFilter> foo(final MyFilter filter) {
        final FilterRegistrationBean<MyFilter> bean = new FilterRegistrationBean<>();
        bean.setFilter(filter);
        bean.addUrlPatterns(");
        return bean;
        }
        }


        If MyFilter needs to be constructed more than once then what you've done is fine.






        share|improve this answer














        If MyFilter is only constructed once then it can be a component, which means it will be autowired implicitly.



        @Component
        MyFilter implements Filter {
        private final ServiceToBeInjected;

        // Autowired implicitly
        public MyFilter(ServiceToBeInjected serviceToBeInjected) {
        this.serviceToBeInjected = serviceToBeInjected;
        }
        }


        Your bean can then take the filter as a method parameter



        public class ConfigClass {
        @Bean
        public FilterRegistrationBean<MyFilter> foo(final MyFilter filter) {
        final FilterRegistrationBean<MyFilter> bean = new FilterRegistrationBean<>();
        bean.setFilter(filter);
        bean.addUrlPatterns(");
        return bean;
        }
        }


        If MyFilter needs to be constructed more than once then what you've done is fine.







        share|improve this answer














        share|improve this answer



        share|improve this answer








        edited Nov 12 at 11:46

























        answered Nov 12 at 8:56









        Michael

        18.4k73368




        18.4k73368






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53258493%2finjecting-a-service-in-spring-boot-filter%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Florida Star v. B. J. F.

            Error while running script in elastic search , gateway timeout

            Adding quotations to stringified JSON object values