What's the idiomatic way to convert a Result to a custom Fail impl?











up vote
0
down vote

favorite












Currently, I'm turning a Result into an instance of my error enum that impls Fail like this:



fn bbswitch_write(data: &str) -> Result<(), BbswitchError> {
match fs::write("/proc/acpi/bbswitch", data) {
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
}
}


but this feels very verbose, and I'd rather not write a four-line match statement every time I do something like this:



let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");


Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?



The rest of my code looks something like this:



#[macro_use]
extern crate failure;

use std::fs;
use std::process::exit;
use failure::Error;

#[derive(Debug, Fail)]
enum BbswitchError {
#[fail(display = "bbswitch not available")]
BbswitchNotAvailable {
#[fail(cause)]
cause: std::io::Error,
},
}

fn bbswitch_write(data: &str) -> Result<(), Error> {
match fs::write("/proc/acpi/bbswitch", data) {
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
}
}

fn power_on() -> Result<(), Error> {
bbswitch_write("ON")?;
Ok(())
}

fn main() {
match power_on() {
Ok(_) => {},
Err(_) => exit(1),
}
}









share|improve this question


























    up vote
    0
    down vote

    favorite












    Currently, I'm turning a Result into an instance of my error enum that impls Fail like this:



    fn bbswitch_write(data: &str) -> Result<(), BbswitchError> {
    match fs::write("/proc/acpi/bbswitch", data) {
    Ok(_) => Ok(()),
    Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
    }
    }


    but this feels very verbose, and I'd rather not write a four-line match statement every time I do something like this:



    let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");


    Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?



    The rest of my code looks something like this:



    #[macro_use]
    extern crate failure;

    use std::fs;
    use std::process::exit;
    use failure::Error;

    #[derive(Debug, Fail)]
    enum BbswitchError {
    #[fail(display = "bbswitch not available")]
    BbswitchNotAvailable {
    #[fail(cause)]
    cause: std::io::Error,
    },
    }

    fn bbswitch_write(data: &str) -> Result<(), Error> {
    match fs::write("/proc/acpi/bbswitch", data) {
    Ok(_) => Ok(()),
    Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
    }
    }

    fn power_on() -> Result<(), Error> {
    bbswitch_write("ON")?;
    Ok(())
    }

    fn main() {
    match power_on() {
    Ok(_) => {},
    Err(_) => exit(1),
    }
    }









    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      Currently, I'm turning a Result into an instance of my error enum that impls Fail like this:



      fn bbswitch_write(data: &str) -> Result<(), BbswitchError> {
      match fs::write("/proc/acpi/bbswitch", data) {
      Ok(_) => Ok(()),
      Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
      }
      }


      but this feels very verbose, and I'd rather not write a four-line match statement every time I do something like this:



      let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");


      Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?



      The rest of my code looks something like this:



      #[macro_use]
      extern crate failure;

      use std::fs;
      use std::process::exit;
      use failure::Error;

      #[derive(Debug, Fail)]
      enum BbswitchError {
      #[fail(display = "bbswitch not available")]
      BbswitchNotAvailable {
      #[fail(cause)]
      cause: std::io::Error,
      },
      }

      fn bbswitch_write(data: &str) -> Result<(), Error> {
      match fs::write("/proc/acpi/bbswitch", data) {
      Ok(_) => Ok(()),
      Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
      }
      }

      fn power_on() -> Result<(), Error> {
      bbswitch_write("ON")?;
      Ok(())
      }

      fn main() {
      match power_on() {
      Ok(_) => {},
      Err(_) => exit(1),
      }
      }









      share|improve this question













      Currently, I'm turning a Result into an instance of my error enum that impls Fail like this:



      fn bbswitch_write(data: &str) -> Result<(), BbswitchError> {
      match fs::write("/proc/acpi/bbswitch", data) {
      Ok(_) => Ok(()),
      Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
      }
      }


      but this feels very verbose, and I'd rather not write a four-line match statement every time I do something like this:



      let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");


      Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?



      The rest of my code looks something like this:



      #[macro_use]
      extern crate failure;

      use std::fs;
      use std::process::exit;
      use failure::Error;

      #[derive(Debug, Fail)]
      enum BbswitchError {
      #[fail(display = "bbswitch not available")]
      BbswitchNotAvailable {
      #[fail(cause)]
      cause: std::io::Error,
      },
      }

      fn bbswitch_write(data: &str) -> Result<(), Error> {
      match fs::write("/proc/acpi/bbswitch", data) {
      Ok(_) => Ok(()),
      Err(e) => Err(BbswitchError::BbswitchNotAvailable { cause: e }.into()),
      }
      }

      fn power_on() -> Result<(), Error> {
      bbswitch_write("ON")?;
      Ok(())
      }

      fn main() {
      match power_on() {
      Ok(_) => {},
      Err(_) => exit(1),
      }
      }






      rust






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 10 at 21:32









      Josh

      1,5431821




      1,5431821
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          1
          down vote













          That very simple just use map_err():



          fs::write("/proc/acpi/bbswitch", data)
          .map_err(|e| BbswitchError::BbswitchNotAvailable { cause: e }.into())





          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














             

            draft saved


            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53243613%2fwhats-the-idiomatic-way-to-convert-a-result-to-a-custom-fail-impl%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            1
            down vote













            That very simple just use map_err():



            fs::write("/proc/acpi/bbswitch", data)
            .map_err(|e| BbswitchError::BbswitchNotAvailable { cause: e }.into())





            share|improve this answer

























              up vote
              1
              down vote













              That very simple just use map_err():



              fs::write("/proc/acpi/bbswitch", data)
              .map_err(|e| BbswitchError::BbswitchNotAvailable { cause: e }.into())





              share|improve this answer























                up vote
                1
                down vote










                up vote
                1
                down vote









                That very simple just use map_err():



                fs::write("/proc/acpi/bbswitch", data)
                .map_err(|e| BbswitchError::BbswitchNotAvailable { cause: e }.into())





                share|improve this answer












                That very simple just use map_err():



                fs::write("/proc/acpi/bbswitch", data)
                .map_err(|e| BbswitchError::BbswitchNotAvailable { cause: e }.into())






                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 11 at 11:53









                Stargateur

                7,65941845




                7,65941845






























                     

                    draft saved


                    draft discarded



















































                     


                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53243613%2fwhats-the-idiomatic-way-to-convert-a-result-to-a-custom-fail-impl%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Florida Star v. B. J. F.

                    Danny Elfman

                    Lugert, Oklahoma