Xamarin forms page doesn't load until async call is done












0














I'm trying to open a new page which shows a list that is populated with data from the server. The call to get the data from the server is done using an async function that is called from OnAppearing method. However, even though the method is async, my UI page is not shown until the call is done. How can I fix that or what is the best practice to make this call?



This is my XAML code for the page:



<StackLayout>
<Label
x:Name="NoPostsMessage"
Text="You have not created any posts yet :("
VerticalOptions="CenterAndExpand"
HorizontalOptions="CenterAndExpand" />

<ListView
x:Name="PostList"
SelectionMode="None">
<ListView.ItemTemplate>
<DataTemplate>
<TextCell Text="{Binding Text}" Detail="{Binding Detail}" />
</DataTemplate>
</ListView.ItemTemplate>
</ListView>
</StackLayout>


This is my C# code:



protected override void OnAppearing()
{
base.OnAppearing();

GetContributions();
}

async private void GetContributions()
{
HttpClient client = new HttpClient();

client.DefaultRequestHeaders.Add("Accept", "application/json");

HttpResponseMessage response = await client
.GetAsync
(
"websiteURL.com"
);

if (response.IsSuccessStatusCode)
{
APIResponse data = JsonConvert.DeserializeObject<APIResponse>(response.Content.ReadAsStringAsync().Result);
if (data.ResponseCode == 1)
{
string payloadData = data.Data.ToString();
List<TextCell> userPosts = JsonConvert.DeserializeObject<List<TextCell>>(payloadData);

if (userPosts.Count == 0)
{
NoPostsMessage.IsVisible = true;
PostList.IsVisible = false;
}
else
{
NoPostsMessage.IsVisible = false;
PostList.IsVisible = true;

ReportsList.ItemsSource = userPosts;
}
}
else
{
await DisplayAlert("Error", data.ErrorMessage, "OK");
}
}
else
{
await DisplayAlert("Error", "An error has occurred, please try again later", "OK");
}
}









share|improve this question






















  • Why are you using .Result in a async method?
    – Cheesebaron
    Nov 13 '18 at 16:07










  • @Cheesebaron, Thanks for pointing that out. I forgot to change that when I changed the method to async. I'll replace it with await
    – Farshad Momtaz
    Nov 14 '18 at 4:30
















0














I'm trying to open a new page which shows a list that is populated with data from the server. The call to get the data from the server is done using an async function that is called from OnAppearing method. However, even though the method is async, my UI page is not shown until the call is done. How can I fix that or what is the best practice to make this call?



This is my XAML code for the page:



<StackLayout>
<Label
x:Name="NoPostsMessage"
Text="You have not created any posts yet :("
VerticalOptions="CenterAndExpand"
HorizontalOptions="CenterAndExpand" />

<ListView
x:Name="PostList"
SelectionMode="None">
<ListView.ItemTemplate>
<DataTemplate>
<TextCell Text="{Binding Text}" Detail="{Binding Detail}" />
</DataTemplate>
</ListView.ItemTemplate>
</ListView>
</StackLayout>


This is my C# code:



protected override void OnAppearing()
{
base.OnAppearing();

GetContributions();
}

async private void GetContributions()
{
HttpClient client = new HttpClient();

client.DefaultRequestHeaders.Add("Accept", "application/json");

HttpResponseMessage response = await client
.GetAsync
(
"websiteURL.com"
);

if (response.IsSuccessStatusCode)
{
APIResponse data = JsonConvert.DeserializeObject<APIResponse>(response.Content.ReadAsStringAsync().Result);
if (data.ResponseCode == 1)
{
string payloadData = data.Data.ToString();
List<TextCell> userPosts = JsonConvert.DeserializeObject<List<TextCell>>(payloadData);

if (userPosts.Count == 0)
{
NoPostsMessage.IsVisible = true;
PostList.IsVisible = false;
}
else
{
NoPostsMessage.IsVisible = false;
PostList.IsVisible = true;

ReportsList.ItemsSource = userPosts;
}
}
else
{
await DisplayAlert("Error", data.ErrorMessage, "OK");
}
}
else
{
await DisplayAlert("Error", "An error has occurred, please try again later", "OK");
}
}









share|improve this question






















  • Why are you using .Result in a async method?
    – Cheesebaron
    Nov 13 '18 at 16:07










  • @Cheesebaron, Thanks for pointing that out. I forgot to change that when I changed the method to async. I'll replace it with await
    – Farshad Momtaz
    Nov 14 '18 at 4:30














0












0








0







I'm trying to open a new page which shows a list that is populated with data from the server. The call to get the data from the server is done using an async function that is called from OnAppearing method. However, even though the method is async, my UI page is not shown until the call is done. How can I fix that or what is the best practice to make this call?



This is my XAML code for the page:



<StackLayout>
<Label
x:Name="NoPostsMessage"
Text="You have not created any posts yet :("
VerticalOptions="CenterAndExpand"
HorizontalOptions="CenterAndExpand" />

<ListView
x:Name="PostList"
SelectionMode="None">
<ListView.ItemTemplate>
<DataTemplate>
<TextCell Text="{Binding Text}" Detail="{Binding Detail}" />
</DataTemplate>
</ListView.ItemTemplate>
</ListView>
</StackLayout>


This is my C# code:



protected override void OnAppearing()
{
base.OnAppearing();

GetContributions();
}

async private void GetContributions()
{
HttpClient client = new HttpClient();

client.DefaultRequestHeaders.Add("Accept", "application/json");

HttpResponseMessage response = await client
.GetAsync
(
"websiteURL.com"
);

if (response.IsSuccessStatusCode)
{
APIResponse data = JsonConvert.DeserializeObject<APIResponse>(response.Content.ReadAsStringAsync().Result);
if (data.ResponseCode == 1)
{
string payloadData = data.Data.ToString();
List<TextCell> userPosts = JsonConvert.DeserializeObject<List<TextCell>>(payloadData);

if (userPosts.Count == 0)
{
NoPostsMessage.IsVisible = true;
PostList.IsVisible = false;
}
else
{
NoPostsMessage.IsVisible = false;
PostList.IsVisible = true;

ReportsList.ItemsSource = userPosts;
}
}
else
{
await DisplayAlert("Error", data.ErrorMessage, "OK");
}
}
else
{
await DisplayAlert("Error", "An error has occurred, please try again later", "OK");
}
}









share|improve this question













I'm trying to open a new page which shows a list that is populated with data from the server. The call to get the data from the server is done using an async function that is called from OnAppearing method. However, even though the method is async, my UI page is not shown until the call is done. How can I fix that or what is the best practice to make this call?



This is my XAML code for the page:



<StackLayout>
<Label
x:Name="NoPostsMessage"
Text="You have not created any posts yet :("
VerticalOptions="CenterAndExpand"
HorizontalOptions="CenterAndExpand" />

<ListView
x:Name="PostList"
SelectionMode="None">
<ListView.ItemTemplate>
<DataTemplate>
<TextCell Text="{Binding Text}" Detail="{Binding Detail}" />
</DataTemplate>
</ListView.ItemTemplate>
</ListView>
</StackLayout>


This is my C# code:



protected override void OnAppearing()
{
base.OnAppearing();

GetContributions();
}

async private void GetContributions()
{
HttpClient client = new HttpClient();

client.DefaultRequestHeaders.Add("Accept", "application/json");

HttpResponseMessage response = await client
.GetAsync
(
"websiteURL.com"
);

if (response.IsSuccessStatusCode)
{
APIResponse data = JsonConvert.DeserializeObject<APIResponse>(response.Content.ReadAsStringAsync().Result);
if (data.ResponseCode == 1)
{
string payloadData = data.Data.ToString();
List<TextCell> userPosts = JsonConvert.DeserializeObject<List<TextCell>>(payloadData);

if (userPosts.Count == 0)
{
NoPostsMessage.IsVisible = true;
PostList.IsVisible = false;
}
else
{
NoPostsMessage.IsVisible = false;
PostList.IsVisible = true;

ReportsList.ItemsSource = userPosts;
}
}
else
{
await DisplayAlert("Error", data.ErrorMessage, "OK");
}
}
else
{
await DisplayAlert("Error", "An error has occurred, please try again later", "OK");
}
}






c# xaml xamarin xamarin.forms






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 12 '18 at 20:14









Farshad MomtazFarshad Momtaz

1691417




1691417












  • Why are you using .Result in a async method?
    – Cheesebaron
    Nov 13 '18 at 16:07










  • @Cheesebaron, Thanks for pointing that out. I forgot to change that when I changed the method to async. I'll replace it with await
    – Farshad Momtaz
    Nov 14 '18 at 4:30


















  • Why are you using .Result in a async method?
    – Cheesebaron
    Nov 13 '18 at 16:07










  • @Cheesebaron, Thanks for pointing that out. I forgot to change that when I changed the method to async. I'll replace it with await
    – Farshad Momtaz
    Nov 14 '18 at 4:30
















Why are you using .Result in a async method?
– Cheesebaron
Nov 13 '18 at 16:07




Why are you using .Result in a async method?
– Cheesebaron
Nov 13 '18 at 16:07












@Cheesebaron, Thanks for pointing that out. I forgot to change that when I changed the method to async. I'll replace it with await
– Farshad Momtaz
Nov 14 '18 at 4:30




@Cheesebaron, Thanks for pointing that out. I forgot to change that when I changed the method to async. I'll replace it with await
– Farshad Momtaz
Nov 14 '18 at 4:30












1 Answer
1






active

oldest

votes


















2














if you do not use await, the async call will block the UI



protected async override void OnAppearing()
{
base.OnAppearing();

await GetContributions();
}





share|improve this answer





















    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269436%2fxamarin-forms-page-doesnt-load-until-async-call-is-done%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    2














    if you do not use await, the async call will block the UI



    protected async override void OnAppearing()
    {
    base.OnAppearing();

    await GetContributions();
    }





    share|improve this answer


























      2














      if you do not use await, the async call will block the UI



      protected async override void OnAppearing()
      {
      base.OnAppearing();

      await GetContributions();
      }





      share|improve this answer
























        2












        2








        2






        if you do not use await, the async call will block the UI



        protected async override void OnAppearing()
        {
        base.OnAppearing();

        await GetContributions();
        }





        share|improve this answer












        if you do not use await, the async call will block the UI



        protected async override void OnAppearing()
        {
        base.OnAppearing();

        await GetContributions();
        }






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 12 '18 at 20:17









        JasonJason

        50.8k1290117




        50.8k1290117






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269436%2fxamarin-forms-page-doesnt-load-until-async-call-is-done%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Florida Star v. B. J. F.

            Danny Elfman

            Lugert, Oklahoma