Ndtyjky

I am getting an error for dateClose.closing, "use is unassigned local variable". I declared dateClose outside of the for loop and defined the value inside the for loop. How can I make that value available outside of the for loop?

public class SMA

{

    public Models.DateClose SMAMethod (Queue<Models.DateClose> queue, int period)

    {

        decimal average, sum=0;

        Models.DateClose dateClose;

        for (int i = 0; i < period; i++)

        {

            dateClose = queue.Dequeue();

            sum += dateClose.Close;

        }

        average = sum/period;

        dateClose.Close = average;  <--- error



        return dateClose;



    }

}

you can simply fix the error by doing

Models.DateClose dateClose = null;

however you would also want to add a null check to make sure you don't run into null ref exception if queue has no item.

You can do this. If your period variable is greater than the queue count than dateClose.Close will throw an exception.

public Models.DateClose SMAMethod (Queue<Models.DateClose> queue, int period)

{

    decimal average, sum=0;

    Models.DateClose dateClose = null;

    for (int i = 0; i < period; i++)

    {

        dateClose = queue.Dequeue();



        if(dateClose != null)

            sum += dateClose.Close;

    }



    average = sum/period;

    dateClose.Close = average;  



    return dateClose;



}

Why do you get this error:

if you have the class, member variables neednot be initialized:

public class Test

{

    private int temp; // this is okay.



..

}

However, if you have a local variable, then you need to initialize them:

public void Method()

{

int variabl; 



sum += variable; // error.

}

So, local variables need to be initialized but member variables neednt be.