Update height with minimal recalculate style impact
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
I've got this little function going inside my onScroll event.
service.updateNotOpenBoxHeight = () => {
let containerHeightWithScrollbar = $('#container').height() - scrollHeight;
let tableHeight = $('#table').height();
let height = tableHeight >= containerHeightWithScrollbar ? tableHeight : containerHeightWithScrollbar;
$('.not-open-box').height(height);
};
And when I inspect via the Performance tab in Chrome it does a bit of recalculating styles.
And I get that red line that says forced reflow, and it's likely a performance bottleneck.
The .not-open-box elements that I am changing the height of can be anywhere from 10 to 50, if that matters.
Is there a better way to do this, in order to improve performance?
Thank you very much
javascript jquery
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
add a comment |
I've got this little function going inside my onScroll event.
service.updateNotOpenBoxHeight = () => {
let containerHeightWithScrollbar = $('#container').height() - scrollHeight;
let tableHeight = $('#table').height();
let height = tableHeight >= containerHeightWithScrollbar ? tableHeight : containerHeightWithScrollbar;
$('.not-open-box').height(height);
};
And when I inspect via the Performance tab in Chrome it does a bit of recalculating styles.
And I get that red line that says forced reflow, and it's likely a performance bottleneck.
The .not-open-box elements that I am changing the height of can be anywhere from 10 to 50, if that matters.
Is there a better way to do this, in order to improve performance?
Thank you very much
javascript jquery
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
2
First thing you should do is cache the jQuery objects so you don't have to search the dom for them every time you move a pixel scrolling. Scroll event fires many many times while scrolling. Adding some "throttling" would cut down a lot of repaint also. Do a web search for "throttling" and "debounce"
– charlietfl
Nov 16 '18 at 19:21
add a comment |
I've got this little function going inside my onScroll event.
service.updateNotOpenBoxHeight = () => {
let containerHeightWithScrollbar = $('#container').height() - scrollHeight;
let tableHeight = $('#table').height();
let height = tableHeight >= containerHeightWithScrollbar ? tableHeight : containerHeightWithScrollbar;
$('.not-open-box').height(height);
};
And when I inspect via the Performance tab in Chrome it does a bit of recalculating styles.
And I get that red line that says forced reflow, and it's likely a performance bottleneck.
The .not-open-box elements that I am changing the height of can be anywhere from 10 to 50, if that matters.
Is there a better way to do this, in order to improve performance?
Thank you very much
javascript jquery
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
I've got this little function going inside my onScroll event.
service.updateNotOpenBoxHeight = () => {
let containerHeightWithScrollbar = $('#container').height() - scrollHeight;
let tableHeight = $('#table').height();
let height = tableHeight >= containerHeightWithScrollbar ? tableHeight : containerHeightWithScrollbar;
$('.not-open-box').height(height);
};
And when I inspect via the Performance tab in Chrome it does a bit of recalculating styles.
And I get that red line that says forced reflow, and it's likely a performance bottleneck.
The .not-open-box elements that I am changing the height of can be anywhere from 10 to 50, if that matters.
Is there a better way to do this, in order to improve performance?
Thank you very much
javascript jquery
javascript jquery
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
edited Nov 16 '18 at 19:18
charlietfl
142k1391126
142k1391126
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
asked Nov 16 '18 at 19:16
Anton AntonsenAnton Antonsen
154
154
2
First thing you should do is cache the jQuery objects so you don't have to search the dom for them every time you move a pixel scrolling. Scroll event fires many many times while scrolling. Adding some "throttling" would cut down a lot of repaint also. Do a web search for "throttling" and "debounce"
– charlietfl
Nov 16 '18 at 19:21
add a comment |
2
First thing you should do is cache the jQuery objects so you don't have to search the dom for them every time you move a pixel scrolling. Scroll event fires many many times while scrolling. Adding some "throttling" would cut down a lot of repaint also. Do a web search for "throttling" and "debounce"
– charlietfl
Nov 16 '18 at 19:21
2
2
First thing you should do is cache the jQuery objects so you don't have to search the dom for them every time you move a pixel scrolling. Scroll event fires many many times while scrolling. Adding some "throttling" would cut down a lot of repaint also. Do a web search for "throttling" and "debounce"
– charlietfl
Nov 16 '18 at 19:21
First thing you should do is cache the jQuery objects so you don't have to search the dom for them every time you move a pixel scrolling. Scroll event fires many many times while scrolling. Adding some "throttling" would cut down a lot of repaint also. Do a web search for "throttling" and "debounce"
– charlietfl
Nov 16 '18 at 19:21
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53344081%2fupdate-height-with-minimal-recalculate-style-impact%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53344081%2fupdate-height-with-minimal-recalculate-style-impact%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
2
First thing you should do is cache the jQuery objects so you don't have to search the dom for them every time you move a pixel scrolling. Scroll event fires many many times while scrolling. Adding some "throttling" would cut down a lot of repaint also. Do a web search for "throttling" and "debounce"
– charlietfl
Nov 16 '18 at 19:21