Displaying false result, while the query returned true











up vote
1
down vote

favorite












I am trying to execute the below code.



Execution gets success, but it is displaying sorry, Query could not execute...



My Codes:



class.php



public function admin_update($id,$update,$value)
{
try{
$stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
$stmt->bindparam(":_value",$value);
$stmt->bindparam(":_id",$id);
$stmt->execute();
}
catch(PDOException $ex)
{
echo $ex->getMessage();
}
}


update.php



$id = "1";

if(admin_update($id,"Access","Y"))
{
echo "Success";
}
else
{
echo "sorry, Query could not execute...";
}


MySQL table is updated, but it does not display Success, instead, it displays sorry, Query could not execute...










share|improve this question


























    up vote
    1
    down vote

    favorite












    I am trying to execute the below code.



    Execution gets success, but it is displaying sorry, Query could not execute...



    My Codes:



    class.php



    public function admin_update($id,$update,$value)
    {
    try{
    $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
    $stmt->bindparam(":_value",$value);
    $stmt->bindparam(":_id",$id);
    $stmt->execute();
    }
    catch(PDOException $ex)
    {
    echo $ex->getMessage();
    }
    }


    update.php



    $id = "1";

    if(admin_update($id,"Access","Y"))
    {
    echo "Success";
    }
    else
    {
    echo "sorry, Query could not execute...";
    }


    MySQL table is updated, but it does not display Success, instead, it displays sorry, Query could not execute...










    share|improve this question
























      up vote
      1
      down vote

      favorite









      up vote
      1
      down vote

      favorite











      I am trying to execute the below code.



      Execution gets success, but it is displaying sorry, Query could not execute...



      My Codes:



      class.php



      public function admin_update($id,$update,$value)
      {
      try{
      $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
      $stmt->bindparam(":_value",$value);
      $stmt->bindparam(":_id",$id);
      $stmt->execute();
      }
      catch(PDOException $ex)
      {
      echo $ex->getMessage();
      }
      }


      update.php



      $id = "1";

      if(admin_update($id,"Access","Y"))
      {
      echo "Success";
      }
      else
      {
      echo "sorry, Query could not execute...";
      }


      MySQL table is updated, but it does not display Success, instead, it displays sorry, Query could not execute...










      share|improve this question













      I am trying to execute the below code.



      Execution gets success, but it is displaying sorry, Query could not execute...



      My Codes:



      class.php



      public function admin_update($id,$update,$value)
      {
      try{
      $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
      $stmt->bindparam(":_value",$value);
      $stmt->bindparam(":_id",$id);
      $stmt->execute();
      }
      catch(PDOException $ex)
      {
      echo $ex->getMessage();
      }
      }


      update.php



      $id = "1";

      if(admin_update($id,"Access","Y"))
      {
      echo "Success";
      }
      else
      {
      echo "sorry, Query could not execute...";
      }


      MySQL table is updated, but it does not display Success, instead, it displays sorry, Query could not execute...







      php mysqli pdo sql-update






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 11 at 6:29









      namo

      195




      195
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          1
          down vote



          accepted










          You need to return the result of execute(). Since you are not returning anything, it is by default considered as null, hence your if() condition is always checking it as false, and going to the else() part.



          public function admin_update($id,$update,$value)
          {
          try{
          $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
          $stmt->bindparam(":_value",$value);
          $stmt->bindparam(":_id",$id);
          return $stmt->execute(); // return the result of execute
          }
          catch(PDOException $ex)
          {
          echo $ex->getMessage();
          return 0; // return 0 in case of failure
          }
          }





          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53246391%2fdisplaying-false-result-while-the-query-returned-true%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            1
            down vote



            accepted










            You need to return the result of execute(). Since you are not returning anything, it is by default considered as null, hence your if() condition is always checking it as false, and going to the else() part.



            public function admin_update($id,$update,$value)
            {
            try{
            $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
            $stmt->bindparam(":_value",$value);
            $stmt->bindparam(":_id",$id);
            return $stmt->execute(); // return the result of execute
            }
            catch(PDOException $ex)
            {
            echo $ex->getMessage();
            return 0; // return 0 in case of failure
            }
            }





            share|improve this answer

























              up vote
              1
              down vote



              accepted










              You need to return the result of execute(). Since you are not returning anything, it is by default considered as null, hence your if() condition is always checking it as false, and going to the else() part.



              public function admin_update($id,$update,$value)
              {
              try{
              $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
              $stmt->bindparam(":_value",$value);
              $stmt->bindparam(":_id",$id);
              return $stmt->execute(); // return the result of execute
              }
              catch(PDOException $ex)
              {
              echo $ex->getMessage();
              return 0; // return 0 in case of failure
              }
              }





              share|improve this answer























                up vote
                1
                down vote



                accepted







                up vote
                1
                down vote



                accepted






                You need to return the result of execute(). Since you are not returning anything, it is by default considered as null, hence your if() condition is always checking it as false, and going to the else() part.



                public function admin_update($id,$update,$value)
                {
                try{
                $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
                $stmt->bindparam(":_value",$value);
                $stmt->bindparam(":_id",$id);
                return $stmt->execute(); // return the result of execute
                }
                catch(PDOException $ex)
                {
                echo $ex->getMessage();
                return 0; // return 0 in case of failure
                }
                }





                share|improve this answer












                You need to return the result of execute(). Since you are not returning anything, it is by default considered as null, hence your if() condition is always checking it as false, and going to the else() part.



                public function admin_update($id,$update,$value)
                {
                try{
                $stmt = $this->conn->prepare("UPDATE admin SET ".$update."=:_value WHERE Id=:_id");
                $stmt->bindparam(":_value",$value);
                $stmt->bindparam(":_id",$id);
                return $stmt->execute(); // return the result of execute
                }
                catch(PDOException $ex)
                {
                echo $ex->getMessage();
                return 0; // return 0 in case of failure
                }
                }






                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 11 at 6:30









                Madhur Bhaiya

                18.8k62236




                18.8k62236






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53246391%2fdisplaying-false-result-while-the-query-returned-true%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    The Sandy Post

                    Danny Elfman

                    Pages that link to "Head v. Amoskeag Manufacturing Co."