Trouble with Dropdown onChanged not dismissing
I have a office-ui-fabric-react dropdown:
<Dropdown
options={hours}
placeHolder={"Hour"}
onChanged={(option: IDropdownOption) => {
this._onChangeHour(option.key+"", field.timePeriod, field.date);
}}
/>
I know it is not best practice to have a function on the callback. I'm fairly new and coded myself into a corner with this. I'd prefer not to have to redo a lot of other stuff to follow best practice.
The issue is when I selected a dropdown item, the dropdown menu is not being dismissed. The onChanged doesn't have a promise or anything, so I don't know how to get the dropdown menu to dismiss now.
If I just pass it a class function to run, it will dismiss. I tried adding return to the end of the function but that did nothing.
Any suggestions?
javascript reactjs typescript
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
add a comment |
I have a office-ui-fabric-react dropdown:
<Dropdown
options={hours}
placeHolder={"Hour"}
onChanged={(option: IDropdownOption) => {
this._onChangeHour(option.key+"", field.timePeriod, field.date);
}}
/>
I know it is not best practice to have a function on the callback. I'm fairly new and coded myself into a corner with this. I'd prefer not to have to redo a lot of other stuff to follow best practice.
The issue is when I selected a dropdown item, the dropdown menu is not being dismissed. The onChanged doesn't have a promise or anything, so I don't know how to get the dropdown menu to dismiss now.
If I just pass it a class function to run, it will dismiss. I tried adding return to the end of the function but that did nothing.
Any suggestions?
javascript reactjs typescript
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
what do u mean by "dismiss"?
– Nirit Levi
Nov 15 '18 at 16:38
@NiritLevi for the dropdown menu to disappear.
– Holden1515
Nov 15 '18 at 16:41
could it be that the first argument of the callback is not the dropdownoption, and the function throws an error or never fulfilled ?
– Nirit Levi
Nov 15 '18 at 16:50
@NiritLevi Oh man, I am I ever an idiot. I had an error that was popping up but missed it. Right now, my SharePoint sandbox is throwing a POST 429 error because it can't connect to some api/collection about every 2 seconds and its spamming me. Thanks for the mention on checking for an error. I appreciate it.
– Holden1515
Nov 15 '18 at 17:00
add a comment |
I have a office-ui-fabric-react dropdown:
<Dropdown
options={hours}
placeHolder={"Hour"}
onChanged={(option: IDropdownOption) => {
this._onChangeHour(option.key+"", field.timePeriod, field.date);
}}
/>
I know it is not best practice to have a function on the callback. I'm fairly new and coded myself into a corner with this. I'd prefer not to have to redo a lot of other stuff to follow best practice.
The issue is when I selected a dropdown item, the dropdown menu is not being dismissed. The onChanged doesn't have a promise or anything, so I don't know how to get the dropdown menu to dismiss now.
If I just pass it a class function to run, it will dismiss. I tried adding return to the end of the function but that did nothing.
Any suggestions?
javascript reactjs typescript
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
I have a office-ui-fabric-react dropdown:
<Dropdown
options={hours}
placeHolder={"Hour"}
onChanged={(option: IDropdownOption) => {
this._onChangeHour(option.key+"", field.timePeriod, field.date);
}}
/>
I know it is not best practice to have a function on the callback. I'm fairly new and coded myself into a corner with this. I'd prefer not to have to redo a lot of other stuff to follow best practice.
The issue is when I selected a dropdown item, the dropdown menu is not being dismissed. The onChanged doesn't have a promise or anything, so I don't know how to get the dropdown menu to dismiss now.
If I just pass it a class function to run, it will dismiss. I tried adding return to the end of the function but that did nothing.
Any suggestions?
javascript reactjs typescript
javascript reactjs typescript
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
asked Nov 15 '18 at 16:27
Holden1515Holden1515
1339
1339
what do u mean by "dismiss"?
– Nirit Levi
Nov 15 '18 at 16:38
@NiritLevi for the dropdown menu to disappear.
– Holden1515
Nov 15 '18 at 16:41
could it be that the first argument of the callback is not the dropdownoption, and the function throws an error or never fulfilled ?
– Nirit Levi
Nov 15 '18 at 16:50
@NiritLevi Oh man, I am I ever an idiot. I had an error that was popping up but missed it. Right now, my SharePoint sandbox is throwing a POST 429 error because it can't connect to some api/collection about every 2 seconds and its spamming me. Thanks for the mention on checking for an error. I appreciate it.
– Holden1515
Nov 15 '18 at 17:00
add a comment |
what do u mean by "dismiss"?
– Nirit Levi
Nov 15 '18 at 16:38
@NiritLevi for the dropdown menu to disappear.
– Holden1515
Nov 15 '18 at 16:41
could it be that the first argument of the callback is not the dropdownoption, and the function throws an error or never fulfilled ?
– Nirit Levi
Nov 15 '18 at 16:50
@NiritLevi Oh man, I am I ever an idiot. I had an error that was popping up but missed it. Right now, my SharePoint sandbox is throwing a POST 429 error because it can't connect to some api/collection about every 2 seconds and its spamming me. Thanks for the mention on checking for an error. I appreciate it.
– Holden1515
Nov 15 '18 at 17:00
what do u mean by "dismiss"?
– Nirit Levi
Nov 15 '18 at 16:38
what do u mean by "dismiss"?
– Nirit Levi
Nov 15 '18 at 16:38
@NiritLevi for the dropdown menu to disappear.
– Holden1515
Nov 15 '18 at 16:41
@NiritLevi for the dropdown menu to disappear.
– Holden1515
Nov 15 '18 at 16:41
could it be that the first argument of the callback is not the dropdownoption, and the function throws an error or never fulfilled ?
– Nirit Levi
Nov 15 '18 at 16:50
could it be that the first argument of the callback is not the dropdownoption, and the function throws an error or never fulfilled ?
– Nirit Levi
Nov 15 '18 at 16:50
@NiritLevi Oh man, I am I ever an idiot. I had an error that was popping up but missed it. Right now, my SharePoint sandbox is throwing a POST 429 error because it can't connect to some api/collection about every 2 seconds and its spamming me. Thanks for the mention on checking for an error. I appreciate it.
– Holden1515
Nov 15 '18 at 17:00
@NiritLevi Oh man, I am I ever an idiot. I had an error that was popping up but missed it. Right now, my SharePoint sandbox is throwing a POST 429 error because it can't connect to some api/collection about every 2 seconds and its spamming me. Thanks for the mention on checking for an error. I appreciate it.
– Holden1515
Nov 15 '18 at 17:00
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53323846%2ftrouble-with-dropdown-onchanged-not-dismissing%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53323846%2ftrouble-with-dropdown-onchanged-not-dismissing%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
what do u mean by "dismiss"?
– Nirit Levi
Nov 15 '18 at 16:38
@NiritLevi for the dropdown menu to disappear.
– Holden1515
Nov 15 '18 at 16:41
could it be that the first argument of the callback is not the dropdownoption, and the function throws an error or never fulfilled ?
– Nirit Levi
Nov 15 '18 at 16:50
@NiritLevi Oh man, I am I ever an idiot. I had an error that was popping up but missed it. Right now, my SharePoint sandbox is throwing a POST 429 error because it can't connect to some api/collection about every 2 seconds and its spamming me. Thanks for the mention on checking for an error. I appreciate it.
– Holden1515
Nov 15 '18 at 17:00