Update Nested Attributes when updating and id provided
I have a model, Report, that has_many Features and accepts_nested_attrubutes_for features.
Class Report < ApplicationRecord
has_many :features, dependent: :destroy
accepts_nested_attributes_for :features
def features_attributes=(features_attributes)
features_attributes.each do |feature_attributes|
f = Feature.by_id_or_map_linkage(feature_attributes)
if f
f.update_attributes(feature_attributes)
else
f = Feature.create(feature_attributes)
end
self.features << f
end
end
end
I've added a method that checks if the feature already exists. I do this check by map_linkage or id, because they are unique fields on the features table.
This works, but is horrible. This logic should be in the Feature model - nested attributes that include one of the identifying fields should trigger an update, not a create.
How can I do this? It feels like this is probably a simple setting I am not aware of or a simple refactoring to the Feature model that would be easier to maintain and avoid duplication in other controllers that update Features through nested_attributes.
ruby-on-rails
asked Nov 12 '18 at 15:53
Will
2,22222646
add a comment |
I have a model, Report, that has_many Features and accepts_nested_attrubutes_for features.
Class Report < ApplicationRecord
has_many :features, dependent: :destroy
accepts_nested_attributes_for :features
def features_attributes=(features_attributes)
features_attributes.each do |feature_attributes|
f = Feature.by_id_or_map_linkage(feature_attributes)
if f
f.update_attributes(feature_attributes)
else
f = Feature.create(feature_attributes)
end
self.features << f
end
end
end
I've added a method that checks if the feature already exists. I do this check by map_linkage or id, because they are unique fields on the features table.
This works, but is horrible. This logic should be in the Feature model - nested attributes that include one of the identifying fields should trigger an update, not a create.
How can I do this? It feels like this is probably a simple setting I am not aware of or a simple refactoring to the Feature model that would be easier to maintain and avoid duplication in other controllers that update Features through nested_attributes.
ruby-on-rails
asked Nov 12 '18 at 15:53
Will
2,22222646
add a comment |
I have a model, Report, that has_many Features and accepts_nested_attrubutes_for features.
Class Report < ApplicationRecord
has_many :features, dependent: :destroy
accepts_nested_attributes_for :features
def features_attributes=(features_attributes)
features_attributes.each do |feature_attributes|
f = Feature.by_id_or_map_linkage(feature_attributes)
if f
f.update_attributes(feature_attributes)
else
f = Feature.create(feature_attributes)
end
self.features << f
end
end
end
I've added a method that checks if the feature already exists. I do this check by map_linkage or id, because they are unique fields on the features table.
This works, but is horrible. This logic should be in the Feature model - nested attributes that include one of the identifying fields should trigger an update, not a create.
How can I do this? It feels like this is probably a simple setting I am not aware of or a simple refactoring to the Feature model that would be easier to maintain and avoid duplication in other controllers that update Features through nested_attributes.
ruby-on-rails
asked Nov 12 '18 at 15:53
Will
2,22222646
I have a model, Report, that has_many Features and accepts_nested_attrubutes_for features.
Class Report < ApplicationRecord
has_many :features, dependent: :destroy
accepts_nested_attributes_for :features
def features_attributes=(features_attributes)
features_attributes.each do |feature_attributes|
f = Feature.by_id_or_map_linkage(feature_attributes)
if f
f.update_attributes(feature_attributes)
else
f = Feature.create(feature_attributes)
end
self.features << f
end
end
end
I've added a method that checks if the feature already exists. I do this check by map_linkage or id, because they are unique fields on the features table.
This works, but is horrible. This logic should be in the Feature model - nested attributes that include one of the identifying fields should trigger an update, not a create.
How can I do this? It feels like this is probably a simple setting I am not aware of or a simple refactoring to the Feature model that would be easier to maintain and avoid duplication in other controllers that update Features through nested_attributes.
ruby-on-rails
ruby-on-rails
asked Nov 12 '18 at 15:53
Will
2,22222646
asked Nov 12 '18 at 15:53
Will
2,22222646
asked Nov 12 '18 at 15:53
Will
2,22222646
asked Nov 12 '18 at 15:53
Will
2,22222646
asked Nov 12 '18 at 15:53
Will
2,22222646
2,22222646
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53265706%2fupdate-nested-attributes-when-updating-and-id-provided%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53265706%2fupdate-nested-attributes-when-updating-and-id-provided%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
