How do I prevent skipped tests from being checked into source control
Using jest to test our javascript / typescript code it's fairly common to wrap a test in either describe.only or it.only While writing and debugging.
This will make jest skip all other tests in the file or block, but it's an easy change to check into source control. I've done it a number of times.
What is the best way to cause tests on CI to fail if any test is skipped? Is there a linter or jest option? I haven't been able to find one.
javascript typescript continuous-integration jestjs
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
add a comment |
Using jest to test our javascript / typescript code it's fairly common to wrap a test in either describe.only or it.only While writing and debugging.
This will make jest skip all other tests in the file or block, but it's an easy change to check into source control. I've done it a number of times.
What is the best way to cause tests on CI to fail if any test is skipped? Is there a linter or jest option? I haven't been able to find one.
javascript typescript continuous-integration jestjs
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
add a comment |
Using jest to test our javascript / typescript code it's fairly common to wrap a test in either describe.only or it.only While writing and debugging.
This will make jest skip all other tests in the file or block, but it's an easy change to check into source control. I've done it a number of times.
What is the best way to cause tests on CI to fail if any test is skipped? Is there a linter or jest option? I haven't been able to find one.
javascript typescript continuous-integration jestjs
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
Using jest to test our javascript / typescript code it's fairly common to wrap a test in either describe.only or it.only While writing and debugging.
This will make jest skip all other tests in the file or block, but it's an easy change to check into source control. I've done it a number of times.
What is the best way to cause tests on CI to fail if any test is skipped? Is there a linter or jest option? I haven't been able to find one.
javascript typescript continuous-integration jestjs
javascript typescript continuous-integration jestjs
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
edited Nov 13 '18 at 0:02
Jared Kells
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
asked Nov 12 '18 at 23:45
Jared KellsJared Kells
4,51333036
4,51333036
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
A linter will do the job.
Add that to your CI job so the tests fail on GitHub etc if the bad code was committed.
You can create a custom rule that rejects presence of jest.it
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
add a comment |
I've done some research since asking the question and I was able to find lint rules to handle this.
For Javascript there's an eslint plugin: https://www.npmjs.com/package/eslint-plugin-no-only-tests
For Typescript there a tslint plugin in the tslint-microsoft-contrib repo: https://github.com/Microsoft/tslint-microsoft-contrib called mocha-avoid-only
I've tested the typescript rule and it works with jest tests. To set it up run: npm install --save-dev tslint-microsoft-contrib then add the following to your tslint configuration.
"rules": {
"mocha-avoid-only": true
},
"rulesDirectory": [
"node_modules/tslint-microsoft-contrib"
],
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53271727%2fhow-do-i-prevent-skipped-tests-from-being-checked-into-source-control%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
A linter will do the job.
Add that to your CI job so the tests fail on GitHub etc if the bad code was committed.
You can create a custom rule that rejects presence of jest.it
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
add a comment |
A linter will do the job.
Add that to your CI job so the tests fail on GitHub etc if the bad code was committed.
You can create a custom rule that rejects presence of jest.it
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
add a comment |
A linter will do the job.
Add that to your CI job so the tests fail on GitHub etc if the bad code was committed.
You can create a custom rule that rejects presence of jest.it
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
A linter will do the job.
Add that to your CI job so the tests fail on GitHub etc if the bad code was committed.
You can create a custom rule that rejects presence of jest.it
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
answered Nov 12 '18 at 23:55
rikAteerikAtee
4,79542956
4,79542956
add a comment |
add a comment |
I've done some research since asking the question and I was able to find lint rules to handle this.
For Javascript there's an eslint plugin: https://www.npmjs.com/package/eslint-plugin-no-only-tests
For Typescript there a tslint plugin in the tslint-microsoft-contrib repo: https://github.com/Microsoft/tslint-microsoft-contrib called mocha-avoid-only
I've tested the typescript rule and it works with jest tests. To set it up run: npm install --save-dev tslint-microsoft-contrib then add the following to your tslint configuration.
"rules": {
"mocha-avoid-only": true
},
"rulesDirectory": [
"node_modules/tslint-microsoft-contrib"
],
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
add a comment |
I've done some research since asking the question and I was able to find lint rules to handle this.
For Javascript there's an eslint plugin: https://www.npmjs.com/package/eslint-plugin-no-only-tests
For Typescript there a tslint plugin in the tslint-microsoft-contrib repo: https://github.com/Microsoft/tslint-microsoft-contrib called mocha-avoid-only
I've tested the typescript rule and it works with jest tests. To set it up run: npm install --save-dev tslint-microsoft-contrib then add the following to your tslint configuration.
"rules": {
"mocha-avoid-only": true
},
"rulesDirectory": [
"node_modules/tslint-microsoft-contrib"
],
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
add a comment |
I've done some research since asking the question and I was able to find lint rules to handle this.
For Javascript there's an eslint plugin: https://www.npmjs.com/package/eslint-plugin-no-only-tests
For Typescript there a tslint plugin in the tslint-microsoft-contrib repo: https://github.com/Microsoft/tslint-microsoft-contrib called mocha-avoid-only
I've tested the typescript rule and it works with jest tests. To set it up run: npm install --save-dev tslint-microsoft-contrib then add the following to your tslint configuration.
"rules": {
"mocha-avoid-only": true
},
"rulesDirectory": [
"node_modules/tslint-microsoft-contrib"
],
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
I've done some research since asking the question and I was able to find lint rules to handle this.
For Javascript there's an eslint plugin: https://www.npmjs.com/package/eslint-plugin-no-only-tests
For Typescript there a tslint plugin in the tslint-microsoft-contrib repo: https://github.com/Microsoft/tslint-microsoft-contrib called mocha-avoid-only
I've tested the typescript rule and it works with jest tests. To set it up run: npm install --save-dev tslint-microsoft-contrib then add the following to your tslint configuration.
"rules": {
"mocha-avoid-only": true
},
"rulesDirectory": [
"node_modules/tslint-microsoft-contrib"
],
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
answered Nov 13 '18 at 0:07
Jared KellsJared Kells
4,51333036
4,51333036
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53271727%2fhow-do-i-prevent-skipped-tests-from-being-checked-into-source-control%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
