Clean methods of class based views












1














Can you confirm that this def clean() override does absolutely nothing in the context of a class based view?



def clean(self):                      
cleaned_data = super(UserAddressForm, self).clean()
address1 = cleaned_data.get('address1')
address2 = cleaned_data.get('address2')
city = cleaned_data.get('city')
state = cleaned_data.get('state')
city = cleaned_data.get('city')
state_other = cleaned_data.get('state_other')
country = cleaned_data.get('country')
country_other = cleaned_data.get('country_other')
zipcode = cleaned_data.get('zipcode')


When I was first learning about django, I believed that:
a) this function did something and,
b) This validation was required for a class based view to confirm that the user inputs didn't contain malicious code.



I don't think a) or b) are correct anymore. Can you confirm?
Thanks!










share|improve this question




















  • 1




    Yes that doesn't do anything. It just declares variables from cleaned_data but does nothing with it. Forms will have clean methods to validate data, and are used by some class based views.
    – markwalker_
    Nov 12 at 1:31










  • Yeah I thought clean methods only applied in the context of forms and models....
    – robotHamster
    Nov 12 at 2:45












  • You don't require to clean everything. It can be used in getting user email or password in the form.
    – Bidhan Majhi
    Nov 12 at 5:32










  • Thanks everyone!
    – Jason Howard
    Nov 12 at 8:18
















1














Can you confirm that this def clean() override does absolutely nothing in the context of a class based view?



def clean(self):                      
cleaned_data = super(UserAddressForm, self).clean()
address1 = cleaned_data.get('address1')
address2 = cleaned_data.get('address2')
city = cleaned_data.get('city')
state = cleaned_data.get('state')
city = cleaned_data.get('city')
state_other = cleaned_data.get('state_other')
country = cleaned_data.get('country')
country_other = cleaned_data.get('country_other')
zipcode = cleaned_data.get('zipcode')


When I was first learning about django, I believed that:
a) this function did something and,
b) This validation was required for a class based view to confirm that the user inputs didn't contain malicious code.



I don't think a) or b) are correct anymore. Can you confirm?
Thanks!










share|improve this question




















  • 1




    Yes that doesn't do anything. It just declares variables from cleaned_data but does nothing with it. Forms will have clean methods to validate data, and are used by some class based views.
    – markwalker_
    Nov 12 at 1:31










  • Yeah I thought clean methods only applied in the context of forms and models....
    – robotHamster
    Nov 12 at 2:45












  • You don't require to clean everything. It can be used in getting user email or password in the form.
    – Bidhan Majhi
    Nov 12 at 5:32










  • Thanks everyone!
    – Jason Howard
    Nov 12 at 8:18














1












1








1







Can you confirm that this def clean() override does absolutely nothing in the context of a class based view?



def clean(self):                      
cleaned_data = super(UserAddressForm, self).clean()
address1 = cleaned_data.get('address1')
address2 = cleaned_data.get('address2')
city = cleaned_data.get('city')
state = cleaned_data.get('state')
city = cleaned_data.get('city')
state_other = cleaned_data.get('state_other')
country = cleaned_data.get('country')
country_other = cleaned_data.get('country_other')
zipcode = cleaned_data.get('zipcode')


When I was first learning about django, I believed that:
a) this function did something and,
b) This validation was required for a class based view to confirm that the user inputs didn't contain malicious code.



I don't think a) or b) are correct anymore. Can you confirm?
Thanks!










share|improve this question















Can you confirm that this def clean() override does absolutely nothing in the context of a class based view?



def clean(self):                      
cleaned_data = super(UserAddressForm, self).clean()
address1 = cleaned_data.get('address1')
address2 = cleaned_data.get('address2')
city = cleaned_data.get('city')
state = cleaned_data.get('state')
city = cleaned_data.get('city')
state_other = cleaned_data.get('state_other')
country = cleaned_data.get('country')
country_other = cleaned_data.get('country_other')
zipcode = cleaned_data.get('zipcode')


When I was first learning about django, I believed that:
a) this function did something and,
b) This validation was required for a class based view to confirm that the user inputs didn't contain malicious code.



I don't think a) or b) are correct anymore. Can you confirm?
Thanks!







django






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 12 at 1:32









markwalker_

4,46553574




4,46553574










asked Nov 12 at 1:20









Jason Howard

1349




1349








  • 1




    Yes that doesn't do anything. It just declares variables from cleaned_data but does nothing with it. Forms will have clean methods to validate data, and are used by some class based views.
    – markwalker_
    Nov 12 at 1:31










  • Yeah I thought clean methods only applied in the context of forms and models....
    – robotHamster
    Nov 12 at 2:45












  • You don't require to clean everything. It can be used in getting user email or password in the form.
    – Bidhan Majhi
    Nov 12 at 5:32










  • Thanks everyone!
    – Jason Howard
    Nov 12 at 8:18














  • 1




    Yes that doesn't do anything. It just declares variables from cleaned_data but does nothing with it. Forms will have clean methods to validate data, and are used by some class based views.
    – markwalker_
    Nov 12 at 1:31










  • Yeah I thought clean methods only applied in the context of forms and models....
    – robotHamster
    Nov 12 at 2:45












  • You don't require to clean everything. It can be used in getting user email or password in the form.
    – Bidhan Majhi
    Nov 12 at 5:32










  • Thanks everyone!
    – Jason Howard
    Nov 12 at 8:18








1




1




Yes that doesn't do anything. It just declares variables from cleaned_data but does nothing with it. Forms will have clean methods to validate data, and are used by some class based views.
– markwalker_
Nov 12 at 1:31




Yes that doesn't do anything. It just declares variables from cleaned_data but does nothing with it. Forms will have clean methods to validate data, and are used by some class based views.
– markwalker_
Nov 12 at 1:31












Yeah I thought clean methods only applied in the context of forms and models....
– robotHamster
Nov 12 at 2:45






Yeah I thought clean methods only applied in the context of forms and models....
– robotHamster
Nov 12 at 2:45














You don't require to clean everything. It can be used in getting user email or password in the form.
– Bidhan Majhi
Nov 12 at 5:32




You don't require to clean everything. It can be used in getting user email or password in the form.
– Bidhan Majhi
Nov 12 at 5:32












Thanks everyone!
– Jason Howard
Nov 12 at 8:18




Thanks everyone!
– Jason Howard
Nov 12 at 8:18

















active

oldest

votes











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53254887%2fclean-methods-of-class-based-views%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown






























active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53254887%2fclean-methods-of-class-based-views%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Florida Star v. B. J. F.

Error while running script in elastic search , gateway timeout

Adding quotations to stringified JSON object values